Do I use salted or unsalted butter for the cake and the icing?

Either will work. For something this sweet, I prefer salted (or I add a little more salt) because salt enhances and rounds out sweetness. There isn't a lot of sugar in the cake, so no need to worry that it would be too salty.

Great question! Unsalted for sure.