Do you use green cardamom seeds?

Antonia James, who wrote the recipe, may report differently.

But yes, for baked goods and snacks, generally use the black seeds from green cardamom pods.
Discard the pods and crush or grind the black seeds.

The black cardamon pods have a smokier, earthier taste and are more often used in savory dishes like curries.