I agree, 2 days. No more. When cool, cover with wax paper and wrap the whole thing in plastic wrap so they don't go stale. Frost or ice on the day you will eat them.

yeah, I wouldn't go beyond two days. If you do, freeze them.

One day is ideal, two days is okay.

I'd feel great about doing them a couple of days in advance. Good heavy, sugary icing helps them keep longer. Keep covered at room temp. You can also freeze unfrosted cupcakes. Defrost and ice before serving.